Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modular-configurations.md: to_lower -> lowercase #1857

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Jasha10
Copy link
Contributor

@Jasha10 Jasha10 commented Mar 15, 2024

I tried running the example from the "Toward modules" section of doc/manual/modular-configurations.md, and I got the following error message:

error: missing field `to_lower`
     ┌─ /home/homestar/tmp/machines.ncl:14:18
     │
  14 │       computed = std.string.to_lower inputs.foo,
     │                  ^^^^^^^^^^^^^^^^^^^ this requires the field `to_lower` to exist
     │
     ┌─ <stdlib/std.ncl>:2295:12
     │
2295 │     string = {
     │ ╭────────────'
2296 │ │     BoolLiteral
2297 │ │       | doc m%"
2298 │ │         Contract for a string representation of a boolean, namely `true` or
     · │
2872 │ │       = fun s => %enum_from_str% s,
2873 │ │   },
     │ ╰───' this record lacks the field `to_lower`

Looking at nickel's standard library docs, I concluded that std.string.to_lower should probably be replaced with std.string.lowercase.

Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the fix! Will backport this to current stable to get the fix up on the website.

@yannham yannham added this pull request to the merge queue Mar 15, 2024
Merged via the queue into tweag:master with commit 1335511 Mar 15, 2024
4 checks passed
@Jasha10 Jasha10 deleted the patch-1 branch March 15, 2024 19:31
@vkleen
Copy link
Contributor

vkleen commented Mar 16, 2024

I've taken the liberty of doing the backport myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants