Or patterns #1916
Merged
Or patterns #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
feat/array-patterns
branch
from
f3b3632
to
0ab9793
Compare
|
🎉 All dependencies have been resolved ! |
jneem
approved these changes
May 24, 2024
yannham
commented
May 24, 2024
yannham
commented
May 24, 2024
yannham
commented
May 24, 2024
yannham
commented
May 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This commit introduces or-patterns, which allows to express alternatives within patterns, including in a deep subpattern. The compilation of or-patterns is rather simple: we simply try each alternative until one matches, and use the corresponding bindings. Typechecking of or-patterns can be done following the same process as for typechecking a whole match expression (which is also a disjunction of patterns), although the treatment of bound variables is a bit different. Most of the complexity of this commit comes from the fact that we don't want to make `or` a reserved language keyword, which would break backward compatibility. This is possible, because `or` in pattern can't be confused with an identifier, but it requires some tweaking to make our LALR(1) parser accept this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1912.
This PR introduces or-patterns, which allows to express alternatives within patterns, including in a deep subpattern.
The compilation of or-patterns is rather simple: we simply try each alternative until one matches, and use the corresponding bindings.
Typechecking of or-patterns can be done following the same process as for typechecking a whole match expression (which is also a disjunction of patterns), although the treatment of bound variables is a bit different.
Most of the complexity of this PR comes from the fact that we don't want to make
ora reserved language keyword, which would break backward compatibility. This is possible, becauseorin pattern can't be confused with an identifier, but it requires some tweaking to make our LALR(1) parser accept this.Syntax
Beside the technicalities around making the grammar unambiguous, this PR also imposes parentheses around enum variant patterns which are part of an or-pattern. That is, it forces to write
('Foo x) or ('Bar x)instead of'Foo x or 'Bar x, which is arguably less readable. Even less so when the identifier isor:'Foo or or 'Bar or😰