Add a contract node to the AST #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
task/contract-ast-node
branch
from
bc4c635
to
2cc8298
Compare
This commit continues the work of properly separating custom contracts in the AST, in order to maintain more run-time information and be able, in the long run, to perform operations like boolean `or` on a larger class of contracts and to provide better error messages in some situations. This commit focuses on predicates, built using the `std.contract.from_predicate` which now acts as some kind of type constructor. `%contract/apply%` then performs the conversion of this predicate to a generic custom contract (a partial identity function). Note that this is a backward-incompatible change on paper, because before one could apply a custom contract built from a predicate as a function (taking a label and a value, and returning a new value). However, in practice, it's not officially supported - users are requested to use `std.contract.apply` to manipulate contracts - and thus we don't expect actual breakage to happen.
yannham
force-pushed
the
task/contract-ast-node
branch
from
2cc8298
to
6384bb5
Compare
jneem
approved these changes
Jun 13, 2024
Co-authored-by: jneem <joeneeman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1954. Related to #1466 and #1460.
This PR continues further the work of properly separating custom contracts in the AST in order to maintain more run-time information and be able, in the long run, to perform operations like boolean
oron a larger class of contracts and to provide better error messages when contracts (in particular parametric contracts) are misused.Note that this is a backward-incompatible change on paper, because before one could apply a custom contract built from a predicate as a function (taking a label and a value, and returning a new value). However, in practice, it's neither officially supported nor recommended - users are requested to use
std.contract.applyto manipulate contracts - and thus we don't expect much actual breakage to happen. If there is breakage, we can always special case the evaluation ofCustomContract::Predicateto act as a function in the evaluator.