Make the LSP configurable #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing that's missing from this is an end-user documentation. But I'm not sure where/how to write it |
yannham
reviewed
Jun 21, 2024
jneem
approved these changes
Jun 21, 2024
|
🎉 All dependencies have been resolved ! |
|
@thufschmitt I'm not sure how to handle the conflict here |
Take into account the configuration sent by the client through [`InitializeParams.initializationOptions`](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initializeParams). This is currently used to set the limits for the background evaluation, although it also creates the infrastructure for setting more things.
Replace it by the derived one (thanks clippy)
Co-Authored-By: Yann Hamdaoui <yann.hamdaoui@tweag.io>
`#[serde(default)]` applied to a whole struct is enough for it to do the right thing with the `Default` trait. Makes the module significantly nicer to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the LSP options configurable
Take into account the configuration sent by the client through
InitializeParams.initializationOptions.This is currently used to set the limits for the background evaluation, although it also creates the infrastructure for setting more things.
Depends on #1973 as they both touch the same code.