[RFC007] New AST for types #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 2079/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 474,510.00 |
| foldl arrays 50 | 📈 view plot | 1,708,900.00 |
| foldl arrays 500 | 📈 view plot | 6,595,900.00 |
| foldr strings 50 | 📈 view plot | 6,973,800.00 |
| foldr strings 500 | 📈 view plot | 61,683,000.00 |
| generate normal 250 | 📈 view plot | 45,232,000.00 |
| generate normal 50 | 📈 view plot | 2,078,600.00 |
| generate normal unchecked 1000 | 📈 view plot | 3,270,600.00 |
| generate normal unchecked 200 | 📈 view plot | 743,050.00 |
| pidigits 100 | 📈 view plot | 3,114,600.00 |
| pipe normal 20 | 📈 view plot | 1,489,400.00 |
| pipe normal 200 | 📈 view plot | 10,223,000.00 |
| product 30 | 📈 view plot | 811,010.00 |
| scalar 10 | 📈 view plot | 1,483,500.00 |
| sum 30 | 📈 view plot | 801,890.00 |
|
🎉 All dependencies have been resolved ! |
yannham
force-pushed
the
rfc007/ast-type
branch
2 times, most recently
from
7631b14
to
f115a5d
Compare
The previous commit introducing the new AST used the "old" type representation from mainline Nickel. Now that `typ::Type` has been made more generic, we can use a better representation that can be arena allocated as well and can contain contracts that are themselves represented in the new AST. This commit integrates this new type representation and add corresponding translation functions from the mainline implementation.
yannham
force-pushed
the
rfc007/ast-type
branch
from
f115a5d
to
7de7b8e
Compare
jneem
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2072
The previous PR #2072 introducing the new AST used the "old" type representation from mainline Nickel. Now that
typ::Typehas been made more generic in #2078, we can use a better representation that can be arena allocated as well and can contain contracts that are themselves represented in the new AST.This PR integrates this new type representation and adds corresponding translation functions from the mainline implementation.