Preliminary changes for bzlmod #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary with bzlmod because `io_tweag_rules_nixpkgs` is not a module (as opposed to rules_nixpkgs_core`, `rules_nixpkgs_python`, etc).
In this version, the runfiles library supports bzlmod
The runfiles library from bazel_tools is deprecated in favor of rules_python
This handle the case where external repositories use the canonical name in bzlmod.
Needed to build //docs:api_html
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes and changes needed to support bzlmod.
Most notably:
runfileslibrary which now support bzlmod (instead of the deprecated one from bazel_tools).rules_nixpkgsrepositories inside the rules_haskell one. This is because repositories likerules_nixpkgs_coreandrules_nixpkgs_pythonare modules which are meant to be used in bzlmod, butio_tweag_rules_nixpkgsis not.IntegrationTesting.hs, to not hardcode the names of external repository folders (which change with bzlmod).