Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nixpkgs will work with Bazel build from source #231

Merged

Conversation

AleksanderGondek
Copy link
Contributor

@AleksanderGondek AleksanderGondek commented May 27, 2022

This commit makes sure, that the checks placed for certain Bazel version will treat Bazel build from source gracefully.

Fixed #229

core/util.bzl Outdated Show resolved Hide resolved
@avdv
Copy link
Member

avdv commented May 30, 2022

Thank you @AleksanderGondek! Let's see if the flaky CI likes your PR...

@AleksanderGondek AleksanderGondek force-pushed the bugfix/usage-with-bazel-build-from-source branch from 9f53e6b to 84fc958 Compare May 30, 2022 10:29
@AleksanderGondek
Copy link
Contributor Author

@avdv It did not like the PR, however I have lost the point of reference after updating the PR :) Would you mind re-triggering?

@AleksanderGondek
Copy link
Contributor Author

This does look like CI-related issues. Am I missing something?

core/util.bzl Outdated Show resolved Hide resolved
core/util.bzl Outdated Show resolved Hide resolved
@avdv avdv force-pushed the bugfix/usage-with-bazel-build-from-source branch from 23b58da to 2c423de Compare May 30, 2022 14:43
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only pushed a fix for a typo

@avdv avdv added the merge-queue merge on green CI label May 30, 2022
@avdv
Copy link
Member

avdv commented May 30, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 30, 2022

rebase

✅ Branch has been successfully rebased

@AleksanderGondek
Copy link
Contributor Author

@avdv Seems the CI is quite not fond of me. :)
Please let me know if there is anything I can do to help!

@avdv
Copy link
Member

avdv commented May 31, 2022

@avdv Seems the CI is quite not fond of me. :)
Please let me know if there is anything I can do to help!

I'll take care of the CI issues - at least we should run through all tests and ensure everything is fine (apart from the buildbuddy crash); e.g. there was still an error when running tests in the core module:

NFO: Analyzed target //docs:update-README.md (46 packages loaded, 268 targets configured).
INFO: Found 1 target...
ERROR: /home/claudio/source/rules_nixpkgs/core/docs/BUILD.bazel:9:23: Generating proto for Starlark doc for __README.md failed: (Exit 1): stardoc failed: error executing command bazel-out/host/bin/external/io_bazel_stardoc/stardoc/stardoc '--input=//:nixpkgs.bzl' '--workspace_name=' '--symbols=nixpkgs_git_repository' '--symbols=nixpkgs_local_repository' ... (remaining 4 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
Stardoc documentation generation failed: File util.bzl imported '@bazel_skylib//lib:versions.bzl', yet external/bazel_skylib/lib/versions.bzl was not found, even at roots [., external/].
Target //docs:update-README.md failed to build
Use --verbose_failures to see the command lines of failed build steps.

Thank you, @AleksanderGondek !

AleksanderGondek and others added 3 commits May 31, 2022 10:25
This commit make sure, that the checks placed for certain Bazel version will treat Bazel build from source gracefuly
@avdv avdv force-pushed the bugfix/usage-with-bazel-build-from-source branch from b8ef079 to 2ea0045 Compare May 31, 2022 08:26
@avdv
Copy link
Member

avdv commented May 31, 2022

CI failed due to a Bazel crash again, but only in the base module and all tests were fine:

//docs:check-README.md                                          (cached) PASSED in 0.1s
//docs:check-readme                                             (cached) PASSED in 0.1s
//tests:run-test-invalid-nixpkgs-package                                 PASSED in 6.4s

...

error: running tests in . was not successful
Error: Process completed with exit code 1.

Going to merge shortly...

@avdv avdv merged commit e554637 into tweag:master May 31, 2022
@mergify mergify bot removed the merge-queue merge on green CI label May 31, 2022
@AleksanderGondek
Copy link
Contributor Author

@avdv Thank you for merging and fixing the missing deps statement - apologies for the one issue that has splipped ;)

@avdv
Copy link
Member

avdv commented May 31, 2022

apologies for the one issue that has splipped ;)

No need to apologise! Thank you again! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when running with a non-release Bazel version
2 participants