-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure nixpkgs will work with Bazel build from source #231
Ensure nixpkgs will work with Bazel build from source #231
Conversation
Thank you @AleksanderGondek! Let's see if the flaky CI likes your PR... |
9f53e6b
to
84fc958
Compare
@avdv It did not like the PR, however I have lost the point of reference after updating the PR :) Would you mind re-triggering? |
This does look like CI-related issues. Am I missing something? |
23b58da
to
2c423de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only pushed a fix for a typo
@Mergifyio rebase |
✅ Branch has been successfully rebased |
2c423de
to
b8ef079
Compare
@avdv Seems the CI is quite not fond of me. :) |
I'll take care of the CI issues - at least we should run through all tests and ensure everything is fine (apart from the buildbuddy crash); e.g. there was still an error when running tests in the
Thank you, @AleksanderGondek ! |
This commit make sure, that the checks placed for certain Bazel version will treat Bazel build from source gracefuly
b8ef079
to
2ea0045
Compare
CI failed due to a Bazel crash again, but only in the base module and all tests were fine:
Going to merge shortly... |
@avdv Thank you for merging and fixing the missing deps statement - apologies for the one issue that has splipped ;) |
No need to apologise! Thank you again! 😄 |
This commit makes sure, that the checks placed for certain Bazel version will treat Bazel build from source gracefully.
Fixed #229