"Modularize" rules_sh #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with bzlmod and addition to the https://github.com/bazelbuild/bazel-central-registry. Adds a module rule `sh_configure` for the POSIX toolchain configured by `sh_posix_configure`. Module rules may invoke repository rules, but may not register toolchains. This commit adds a boolean parameter `register` to `sh_posix_configure` for compatibility with both the old repository rule workflow and the new module workflow.
r2r-dev
approved these changes
Jan 12, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
8 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with bzlmod and addition to the https://github.com/bazelbuild/bazel-central-registry.
This version has been added to the BCR in bazelbuild/bazel-central-registry#38 already. The changes introduced by this PR are so that future versions will no longer require patching to be added to the BCR.
Adds a module rule
sh_configurefor the POSIX toolchain configured bysh_posix_configure. Module rules may invoke repository rules, but may not register toolchains. This commit adds a boolean parameterregistertosh_posix_configurefor compatibility with both the old repository rule workflow and the new module workflow.Adds instructions for creating new Bazel Central Registry entries to
MAINTAINERS.md.Extends CI configuration to test with bzlmod enabled.