Fix invalidated linked entities in node graph #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, Precache() would attempt to renew all linked entity pointers based on their stored model name, however since not all entities are initialized from a saved game during this stage yet, occasionally, the game would fail to renew linked ent pointers and therefore lose reference to doors (etc) that block a traversal path between nodes. The change should ensure we relink referenced entity pointers at a time when all entities are already present, therefore we ensure references are still resolved correctly and the pathfinding continues to work correctly even after we load a saved game. Previous behavior: NPC would fail to navigate through doors on a loaded save. Current behavior: NPC has no issue navigating through doors on a loaded save.
Admittedly, UpdateClientData() is unsuitable place for the logic, PreThink is where it should have been placed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, Precache() would attempt to renew all linked entity pointers based on their stored model name, however since not all entities are initialized from a saved game during this stage yet, occasionally, the game would fail to renew linked ent pointers and therefore lose reference to doors (etc) that block a traversal path between nodes.
The change should ensure we relink referenced entity pointers at a time when all entities are already present, therefore we ensure references are still resolved correctly and the pathfinding continues to work correctly even after we load a saved game.
Previous behavior:
NPC would fail to navigate through doors on a loaded save.
Current behavior:
NPC has no issue navigating through doors on a loaded save.