Fix symlinks to Linux and MacOS builds of SDL2 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were supposed to be symlinks and they are in Valve's repo, but in Solokiller's fork they lost their symlink flag with this commit: twhl-community/halflife-updated@6509102
|
Yeah looks like the files were changed when i touched them on Windows. |
|
That's strange! Does the Windows client not preserve symlinks? Thanks for the merge! |
|
I don't know what happened exactly, my Git client (SourceTree) showed no differences in the file itself, it just listed it as having been replaced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were supposed to be symlinks and they are in Valve's repo, but in yours they lost their symlink flag with this commit:
6509102
I'm not sure if they are really needed for the builds, guess people are expected to link their client libraries against the symlink SDL2 libs.
P.S.: Sorry for not replying earlier on issue 33. It's just life... But yeah, the solution is to not install HLDS.