Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package-lock.json for compatibility with Node.js 10+ #886

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

RobLoach
Copy link
Collaborator

Needs to be compatible with older Node.js's?

@RobLoach
Copy link
Collaborator Author

@willrowe WAT?

@RobLoach RobLoach changed the title Fix package-lock.json Fix dependencies Nov 16, 2023
@willrowe
Copy link
Collaborator

@RobLoach what happened? I don't think anything changed in the dependencies so the lock file shouldn't have changed besides the version number?

@RobLoach
Copy link
Collaborator Author

I believe what happened is that when I ran the tests locally with Node.js 20, it updated the lock file... Which may or may not work on Node.js 10 🙃 .... I'll issue a point fix with this one.

@RobLoach RobLoach changed the title Fix dependencies Fix package-lock.json for compatibility with Node.js 10+ Nov 16, 2023
@RobLoach RobLoach merged commit 9a0850b into master Nov 16, 2023
14 of 19 checks passed
@willrowe
Copy link
Collaborator

Oh my, didn't even realize that could happen. Thanks for the release!

@willrowe willrowe deleted the restore-package-lock branch November 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants