Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize context access on PHP 7.4 #2985

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Apr 27, 2019

No description provided.

@stof
Copy link
Member

stof commented Apr 29, 2019

is array_key_exists optimized by the compiler on PHP 7.4 ? that's a good news

@fabpot
Copy link
Contributor Author

fabpot commented Apr 29, 2019

@stof php/php-src#3360

@stof
Copy link
Member

stof commented Apr 29, 2019

yeah, that's a great news.

CHANGELOG Outdated Show resolved Hide resolved
@fabpot fabpot merged commit 5b5f565 into twigphp:1.x Apr 30, 2019
fabpot added a commit that referenced this pull request Apr 30, 2019
This PR was merged into the 1.x branch.

Discussion
----------

Optimize context access on PHP 7.4

Commits
-------

5b5f565 optimized context access on PHP 7.4
@fabpot fabpot deleted the php74-optimization branch May 1, 2019 13:53
fabpot added a commit that referenced this pull request Feb 12, 2020
This PR was merged into the 1.x branch.

Discussion
----------

Optimize context access on PHP 7.4

`700400` means PHP 70.4

refs #2985

Commits
-------

e3c20d3 Fix optimize context access on PHP 7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants