Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to deprecated "convertToHtml" method #3638

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Fix call to deprecated "convertToHtml" method #3638

merged 1 commit into from
Jan 29, 2022

Conversation

jderusse
Copy link
Contributor

note: We can not rely on the new interface ConverterInterface because this interface already existed in version 1.0

@jderusse jderusse force-pushed the deprec branch 2 times, most recently from 88491ea to 3ec0111 Compare January 29, 2022 14:14
@fabpot fabpot changed the base branch from 3.x to 2.x January 29, 2022 15:33
@fabpot
Copy link
Contributor

fabpot commented Jan 29, 2022

Thank you @jderusse.

@fabpot fabpot merged commit e056e63 into twigphp:2.x Jan 29, 2022
@jderusse jderusse deleted the deprec branch January 29, 2022 16:11
@jderusse
Copy link
Contributor Author

Good catch for the 2.x branch.
I missed that twig 2.x is compatible with common mark 2.x regardless the require-dev section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @fabpot