Minor: Fixing language #3806
Merged
Minor: Fixing language #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Feb 2, 2023
doc/filters/striptags.rst
Outdated
| @@ -1,7 +1,7 @@ | |||
| ``striptags`` | |||
| ============= | |||
|
|
|||
| The ``striptags`` filter strips SGML/XML tags and replace adjacent whitespace | |||
| The ``striptags`` filter strips SGML/XML tags and replaces adjacent whitespaces | |||
There was a problem hiding this comment.
whitespace is unaccountable, so:
Suggested change
| The ``striptags`` filter strips SGML/XML tags and replaces adjacent whitespaces | |
| The ``striptags`` filter strips SGML/XML tags and replaces adjacent whitespace |
There was a problem hiding this comment.
Well, but then "adjacent" sounds weird ;-) => So I went for "whitespace characters", as https://www.php.net/manual/en/regexp.reference.escape.php is doing.
|
Good catch, thanks @ThomasLandauer. |
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Feb 11, 2023
According to twigphp/Twig#3806 (comment) - but I didn't doublecheck.
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 17, 2023
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Changing "white spaces" => "whitespace" According to twigphp/Twig#3806 (comment) - but I didn't doublecheck. Commits ------- 369b563 Changing "white spaces" => "whitespace"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.