-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(summary-detail): fixes issue in react <18 #3741
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: 9d6a214 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Size Change: +25 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
1 failed test on run #7556 ↗︎
Details:
cypress/integration/api/paste-assistant-message.spec.ts • 1 failed test • Paste Docsite integration tests
Review all test suite changes for PR #3741 ↗︎ |
77d8bc0
to
1c25d2e
Compare
1c25d2e
to
f876bf7
Compare
f876bf7
to
547b833
Compare
f616e29
to
b159069
Compare
So there was a leak in jest, which I fixed in the package.json scripts. However there was also a real issue with summaryDetail in React < 18. It was using With all of these fixes, we're back on track! |
See memory leak issue here https://github.com/twilio-labs/paste/actions/runs/7670180581/job/20905756481
Suddenly happening as we added more tests which reached an upper bound by github actions
Research on jest memory leaks here: jestjs/jest#7874
Updated our package.json with a fix that worked locally.