feat:adds details to rest exception (#565)

lib/base/RestException.d.ts

@@ -3,7 +3,7 @@ declare class RestException extends Error {
   message: string;
   code: number;
   moreInfo: string;
-  detail: string;
+  details: object;
 }
 
-export = RestException;
+export = RestException;

lib/base/RestException.js

@@ -4,12 +4,12 @@ class RestException extends Error {
   constructor(response) {
     super('[HTTP ' + response.statusCode + '] Failed to execute request');
 
-    const body = response.body === 'string' ? JSON.parse(response.body) : response.body;
+    const body = typeof response.body === 'string' ? JSON.parse(response.body) : response.body;
     this.status = response.statusCode;
     this.message = body.message;
     this.code = body.code;
     this.moreInfo = body.more_info; /* jshint ignore:line */
-    this.detail = body.detail;
+    this.details = body.details;
   }
 }
 

spec/unit/base/RestException.spec.js

@@ -0,0 +1,55 @@
+var RestException = require('../../../lib/base/RestException');
+
+describe('exception gets created from string', function () {
+  it('should test serialize without details', function () {
+    const response = {
+      statusCode: 200,
+      body: '{"message":"test", "code":81022,"more_info": "https://www.twilio.com/docs/errors/81022"}',
+    };
+    const exception = new RestException(response);
+    expect(exception.status).toEqual(200);
+    expect(exception.message).toEqual('test');
+    expect(exception.code).toEqual(81022);
+    expect(exception.moreInfo).toEqual('https://www.twilio.com/docs/errors/81022');
+  });
+});
+
+describe('exception gets created from json error', function () {
+
+  it('should create exception without details', function () {
+    const response = {
+      statusCode: 200,
+      body: {
+        message: 'test',
+        code: 81022,
+        more_info: 'https://www.twilio.com/docs/errors/81022',
+      },
+    };
+
+    var exception = new RestException(response);
+    expect(exception.status).toEqual(200);
+    expect(exception.message).toEqual('test');
+    expect(exception.code).toEqual(81022);
+    expect(exception.moreInfo).toEqual('https://www.twilio.com/docs/errors/81022');
+    expect(exception.details).toEqual(undefined);
+  });
+
+  it('should create exception with details', function () {
+    const details = {
+      foo: 'bar',
+    };
+
+    const response = {
+      statusCode: 200,
+      body: {
+        message: 'test',
+        code: 81022,
+        more_info: 'https://www.twilio.com/docs/errors/81022',
+        details: details,
+      },
+    };
+
+    const exception = new RestException(response);
+    expect(exception.details).toEqual(details);
+  });
+});