Assign default value to twilioHeader during validation (#446)

* Assign default value to twilioHeader during validation * Added tests for the validation * Fixed test bug where wrong variable was being used * Removed duplicate test
twilio · May 16, 2019 · 5dbef34 · 5dbef34
1 parent 4f80e68
commit 5dbef34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/webhooks/webhooks.js b/lib/webhooks/webhooks.js
@@ -47,6 +47,7 @@ function getExpectedBodyHash(body) {
  @returns {boolean} - valid
  */
 function validateRequest(authToken, twilioHeader, url, params) {
+  twilioHeader = twilioHeader || '';
   var expectedSignature = getExpectedTwilioSignature(authToken, url, params);
   return scmp(Buffer.from(twilioHeader), Buffer.from(expectedSignature));
 }

diff --git a/spec/validation.spec.js b/spec/validation.spec.js
@@ -69,6 +69,12 @@ describe('Request validation', () => {
 
         expect(isValid).toBeFalsy();
     });
+
+    it('should fail when signature undefined', () => {
+        const isValid = validateRequest(token, undefined, requestUrl, defaultParams);
+
+        expect(isValid).toBeFalsy();
+    });
 });
 
 describe('Request validation middleware', () => {