Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the TS return type for various instance and context actions #479

Merged
merged 1 commit into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/rest/accounts/v1/credential/aws.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ declare class AwsContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: AwsInstance) => any): void;
remove(callback?: (error: Error | null, items: AwsInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -240,14 +240,14 @@ declare class AwsInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: AwsInstance) => any): void;
fetch(callback?: (error: Error | null, items: AwsInstance) => any): Promise<AwsInstance>;
friendlyName: string;
/**
* remove a AwsInstance
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: AwsInstance) => any): void;
remove(callback?: (error: Error | null, items: AwsInstance) => any): Promise<boolean>;
sid: string;
/**
* Provide a user-friendly representation
Expand All @@ -259,7 +259,7 @@ declare class AwsInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: AwsInstanceUpdateOptions, callback?: (error: Error | null, items: AwsInstance) => any): void;
update(opts?: AwsInstanceUpdateOptions, callback?: (error: Error | null, items: AwsInstance) => any): Promise<AwsInstance>;
url: string;
}

Expand Down
8 changes: 4 additions & 4 deletions lib/rest/accounts/v1/credential/publicKey.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ declare class PublicKeyContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: PublicKeyInstance) => any): void;
remove(callback?: (error: Error | null, items: PublicKeyInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -240,14 +240,14 @@ declare class PublicKeyInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: PublicKeyInstance) => any): void;
fetch(callback?: (error: Error | null, items: PublicKeyInstance) => any): Promise<PublicKeyInstance>;
friendlyName: string;
/**
* remove a PublicKeyInstance
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: PublicKeyInstance) => any): void;
remove(callback?: (error: Error | null, items: PublicKeyInstance) => any): Promise<boolean>;
sid: string;
/**
* Provide a user-friendly representation
Expand All @@ -259,7 +259,7 @@ declare class PublicKeyInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: PublicKeyInstanceUpdateOptions, callback?: (error: Error | null, items: PublicKeyInstance) => any): void;
update(opts?: PublicKeyInstanceUpdateOptions, callback?: (error: Error | null, items: PublicKeyInstance) => any): Promise<PublicKeyInstance>;
url: string;
}

Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ declare class AccountInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: AccountInstance) => any): void;
fetch(callback?: (error: Error | null, items: AccountInstance) => any): Promise<AccountInstance>;
friendlyName: string;
/**
* Access the incomingPhoneNumbers
Expand Down Expand Up @@ -429,7 +429,7 @@ declare class AccountInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: AccountInstanceUpdateOptions, callback?: (error: Error | null, items: AccountInstance) => any): void;
update(opts?: AccountInstanceUpdateOptions, callback?: (error: Error | null, items: AccountInstance) => any): Promise<AccountInstance>;
uri: string;
/**
* Access the usage
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/address.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ declare class AddressContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: AddressInstance) => any): void;
remove(callback?: (error: Error | null, items: AddressInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -308,7 +308,7 @@ declare class AddressInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: AddressInstance) => any): void;
fetch(callback?: (error: Error | null, items: AddressInstance) => any): Promise<AddressInstance>;
friendlyName: string;
isoCountry: string;
postalCode: string;
Expand All @@ -318,7 +318,7 @@ declare class AddressInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: AddressInstance) => any): void;
remove(callback?: (error: Error | null, items: AddressInstance) => any): Promise<boolean>;
sid: string;
street: string;
/**
Expand All @@ -331,7 +331,7 @@ declare class AddressInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: AddressInstanceUpdateOptions, callback?: (error: Error | null, items: AddressInstance) => any): void;
update(opts?: AddressInstanceUpdateOptions, callback?: (error: Error | null, items: AddressInstance) => any): Promise<AddressInstance>;
uri: string;
validated: boolean;
verified: boolean;
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/application.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ declare class ApplicationContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: ApplicationInstance) => any): void;
remove(callback?: (error: Error | null, items: ApplicationInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -318,15 +318,15 @@ declare class ApplicationInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: ApplicationInstance) => any): void;
fetch(callback?: (error: Error | null, items: ApplicationInstance) => any): Promise<ApplicationInstance>;
friendlyName: string;
messageStatusCallback: string;
/**
* remove a ApplicationInstance
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: ApplicationInstance) => any): void;
remove(callback?: (error: Error | null, items: ApplicationInstance) => any): Promise<boolean>;
sid: string;
smsFallbackMethod: string;
smsFallbackUrl: string;
Expand All @@ -345,7 +345,7 @@ declare class ApplicationInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: ApplicationInstanceUpdateOptions, callback?: (error: Error | null, items: ApplicationInstance) => any): void;
update(opts?: ApplicationInstanceUpdateOptions, callback?: (error: Error | null, items: ApplicationInstance) => any): Promise<ApplicationInstance>;
uri: string;
voiceCallerIdLookup: boolean;
voiceFallbackMethod: string;
Expand Down
2 changes: 1 addition & 1 deletion lib/rest/api/v2010/account/authorizedConnectApp.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ declare class AuthorizedConnectAppInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: AuthorizedConnectAppInstance) => any): void;
fetch(callback?: (error: Error | null, items: AuthorizedConnectAppInstance) => any): Promise<AuthorizedConnectAppInstance>;
permissions: AuthorizedConnectAppPermission[];
/**
* Provide a user-friendly representation
Expand Down
2 changes: 1 addition & 1 deletion lib/rest/api/v2010/account/availablePhoneNumber.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ declare class AvailablePhoneNumberCountryInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: AvailablePhoneNumberCountryInstance) => any): void;
fetch(callback?: (error: Error | null, items: AvailablePhoneNumberCountryInstance) => any): Promise<AvailablePhoneNumberCountryInstance>;
/**
* Access the local
*/
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/call.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ declare class CallContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: CallInstance) => any): void;
remove(callback?: (error: Error | null, items: CallInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -411,7 +411,7 @@ declare class CallInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: CallInstance) => any): void;
fetch(callback?: (error: Error | null, items: CallInstance) => any): Promise<CallInstance>;
forwardedFrom: string;
from: string;
fromFormatted: string;
Expand All @@ -433,7 +433,7 @@ declare class CallInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: CallInstance) => any): void;
remove(callback?: (error: Error | null, items: CallInstance) => any): Promise<boolean>;
sid: string;
startTime: Date;
status: CallStatus;
Expand All @@ -450,7 +450,7 @@ declare class CallInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: CallInstanceUpdateOptions, callback?: (error: Error | null, items: CallInstance) => any): void;
update(opts?: CallInstanceUpdateOptions, callback?: (error: Error | null, items: CallInstance) => any): Promise<CallInstance>;
uri: string;
}

Expand Down
6 changes: 3 additions & 3 deletions lib/rest/api/v2010/account/call/feedback.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ declare class FeedbackInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
create(opts: FeedbackInstanceCreateOptions, callback?: (error: Error | null, items: FeedbackInstance) => any): void;
create(opts: FeedbackInstanceCreateOptions, callback?: (error: Error | null, items: FeedbackInstance) => any): Promise<FeedbackInstance>;
dateCreated: Date;
dateUpdated: Date;
/**
* fetch a FeedbackInstance
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: FeedbackInstance) => any): void;
fetch(callback?: (error: Error | null, items: FeedbackInstance) => any): Promise<FeedbackInstance>;
issues: FeedbackIssues[];
qualityScore: number;
sid: string;
Expand All @@ -155,7 +155,7 @@ declare class FeedbackInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts: FeedbackInstanceUpdateOptions, callback?: (error: Error | null, items: FeedbackInstance) => any): void;
update(opts: FeedbackInstanceUpdateOptions, callback?: (error: Error | null, items: FeedbackInstance) => any): Promise<FeedbackInstance>;
}


Expand Down
6 changes: 3 additions & 3 deletions lib/rest/api/v2010/account/call/feedbackSummary.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ declare class FeedbackSummaryContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): void;
remove(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -139,7 +139,7 @@ declare class FeedbackSummaryInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): void;
fetch(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): Promise<FeedbackSummaryInstance>;
includeSubaccounts: boolean;
issues: string[];
qualityScoreAverage: number;
Expand All @@ -150,7 +150,7 @@ declare class FeedbackSummaryInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): void;
remove(callback?: (error: Error | null, items: FeedbackSummaryInstance) => any): Promise<boolean>;
sid: string;
startDate: Date;
status: FeedbackSummaryStatus;
Expand Down
6 changes: 3 additions & 3 deletions lib/rest/api/v2010/account/call/notification.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ declare class NotificationContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: NotificationInstance) => any): void;
remove(callback?: (error: Error | null, items: NotificationInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -251,7 +251,7 @@ declare class NotificationInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: NotificationInstance) => any): void;
fetch(callback?: (error: Error | null, items: NotificationInstance) => any): Promise<NotificationInstance>;
log: string;
messageDate: Date;
messageText: string;
Expand All @@ -261,7 +261,7 @@ declare class NotificationInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: NotificationInstance) => any): void;
remove(callback?: (error: Error | null, items: NotificationInstance) => any): Promise<boolean>;
requestMethod: string;
requestUrl: string;
requestVariables: string;
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/call/recording.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ declare class RecordingContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: RecordingInstance) => any): void;
remove(callback?: (error: Error | null, items: RecordingInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -295,15 +295,15 @@ declare class RecordingInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: RecordingInstance) => any): void;
fetch(callback?: (error: Error | null, items: RecordingInstance) => any): Promise<RecordingInstance>;
price: number;
priceUnit: string;
/**
* remove a RecordingInstance
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: RecordingInstance) => any): void;
remove(callback?: (error: Error | null, items: RecordingInstance) => any): Promise<boolean>;
sid: string;
source: RecordingSource;
startTime: Date;
Expand All @@ -318,7 +318,7 @@ declare class RecordingInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts: RecordingInstanceUpdateOptions, callback?: (error: Error | null, items: RecordingInstance) => any): void;
update(opts: RecordingInstanceUpdateOptions, callback?: (error: Error | null, items: RecordingInstance) => any): Promise<RecordingInstance>;
uri: string;
}

Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/conference.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ declare class ConferenceInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: ConferenceInstance) => any): void;
fetch(callback?: (error: Error | null, items: ConferenceInstance) => any): Promise<ConferenceInstance>;
friendlyName: string;
/**
* Access the participants
Expand All @@ -310,7 +310,7 @@ declare class ConferenceInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: ConferenceInstanceUpdateOptions, callback?: (error: Error | null, items: ConferenceInstance) => any): void;
update(opts?: ConferenceInstanceUpdateOptions, callback?: (error: Error | null, items: ConferenceInstance) => any): Promise<ConferenceInstance>;
uri: string;
}

Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/conference/participant.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ declare class ParticipantContext {
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: ParticipantInstance) => any): void;
remove(callback?: (error: Error | null, items: ParticipantInstance) => any): Promise<boolean>;
/**
* Provide a user-friendly representation
*/
Expand Down Expand Up @@ -361,15 +361,15 @@ declare class ParticipantInstance extends SerializableClass {
*
* @param callback - Callback to handle processed record
*/
fetch(callback?: (error: Error | null, items: ParticipantInstance) => any): void;
fetch(callback?: (error: Error | null, items: ParticipantInstance) => any): Promise<ParticipantInstance>;
hold: boolean;
muted: boolean;
/**
* remove a ParticipantInstance
*
* @param callback - Callback to handle processed record
*/
remove(callback?: (error: Error | null, items: ParticipantInstance) => any): void;
remove(callback?: (error: Error | null, items: ParticipantInstance) => any): Promise<boolean>;
startConferenceOnEnter: boolean;
status: ParticipantStatus;
/**
Expand All @@ -382,7 +382,7 @@ declare class ParticipantInstance extends SerializableClass {
* @param opts - Options for request
* @param callback - Callback to handle processed record
*/
update(opts?: ParticipantInstanceUpdateOptions, callback?: (error: Error | null, items: ParticipantInstance) => any): void;
update(opts?: ParticipantInstanceUpdateOptions, callback?: (error: Error | null, items: ParticipantInstance) => any): Promise<ParticipantInstance>;
uri: string;
}

Expand Down
Loading