Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few property types in the lookups and trunking responses #488

Merged
merged 1 commit into from
Oct 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/rest/lookups/v1/phoneNumber.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ interface PhoneNumberPayload extends PhoneNumberResource, Page.TwilioResponsePay

interface PhoneNumberResource {
add_ons: object;
caller_name: string;
carrier: string;
caller_name: object;
carrier: object;
country_code: string;
national_format: string;
phone_number: string;
Expand Down Expand Up @@ -104,8 +104,8 @@ declare class PhoneNumberInstance extends SerializableClass {

private _proxy: PhoneNumberContext;
addOns: object;
callerName: string;
carrier: string;
callerName: object;
carrier: object;
countryCode: string;
/**
* fetch a PhoneNumberInstance
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/lookups/v1/phoneNumber.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,11 @@ PhoneNumberPage.prototype[util.inspect.custom] = function inspect(depth,
*
* @constructor Twilio.Lookups.V1.PhoneNumberInstance
*
* @property {string} callerName - The name of the phone number's owner
* @property {object} callerName - The name of the phone number's owner
* @property {string} countryCode - The ISO country code for the phone number
* @property {string} phoneNumber - The phone number in E.164 format
* @property {string} nationalFormat - The phone number, in national format
* @property {string} carrier - The telecom company that provides the phone number
* @property {object} carrier - The telecom company that provides the phone number
* @property {object} addOns -
* A JSON string with the results of the Add-ons you specified
* @property {string} url - The absolute URL of the resource
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/trunking/v1/trunk/phoneNumber.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ interface PhoneNumberResource {
address_requirements: PhoneNumberAddressRequirement;
api_version: string;
beta: boolean;
capabilities: string;
capabilities: object;
date_created: Date;
date_updated: Date;
friendly_name: string;
Expand Down Expand Up @@ -242,7 +242,7 @@ declare class PhoneNumberInstance extends SerializableClass {
addressRequirements: PhoneNumberAddressRequirement;
apiVersion: string;
beta: boolean;
capabilities: string;
capabilities: object;
dateCreated: Date;
dateUpdated: Date;
/**
Expand Down
2 changes: 1 addition & 1 deletion lib/rest/trunking/v1/trunk/phoneNumber.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ PhoneNumberPage.prototype[util.inspect.custom] = function inspect(depth,
* The API version used to start a new TwiML session
* @property {boolean} beta -
* Whether the phone number is new to the Twilio platform
* @property {string} capabilities -
* @property {object} capabilities -
* Indicate if a phone can receive calls or messages
* @property {Date} dateCreated -
* The RFC 2822 date and time in GMT when the resource was created
Expand Down