Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from deprecated request module to axios #542

Merged
merged 2 commits into from
Mar 9, 2020
Merged

feat: migrate from deprecated request module to axios #542

merged 2 commits into from
Mar 9, 2020

Conversation

eshanholtz
Copy link
Contributor

No description provided.

childish-sambino
childish-sambino approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming you've manually tested with a few different request types.

Also, I think this should be marked as a feat in order to roll the minor version since we're migrating to a new dependency.

@eshanholtz eshanholtz changed the title chore: migrate from deprecated request module to axios feat: migrate from deprecated request module to axios Mar 9, 2020
@eshanholtz eshanholtz merged commit 6266910 into master Mar 9, 2020
@eshanholtz eshanholtz deleted the request-to-axios branch March 9, 2020 16:11
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2020
Closed
@stephencaldwell
Copy link
Contributor

This appears to have broken sending get request query parameters. Specifically this line: d547d51#diff-40d11f008feb68598689ff4f74357b7eR76

axios expects it to be paramsSerializer, not paramSerializer.

@childish-sambino
Copy link
Contributor

For reference: #551

@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Closed
@childish-sambino childish-sambino mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshanholtz @stephencaldwell @childish-sambino