Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use datetime instead of date for alert start/end date params #584

Conversation

mebuckler
Copy link
Contributor

@mebuckler mebuckler commented Jun 11, 2020

Fixes #585

This fixes the issue with the alert endpoint not using the time when specifying the date/time to limit the results.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@childish-sambino childish-sambino changed the title use datetime instead of date fix: use datetime instead of date for alert start/end date params Jun 11, 2020
@childish-sambino childish-sambino merged commit 565cc4c into twilio:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts Ignores Time Specified
2 participants