feat: add regional twr header in the access token #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanholtz
reviewed
Oct 23, 2020
eshanholtz
reviewed
Oct 23, 2020
charliesantos
force-pushed
the
regional_twr_header_support
branch
from
fb668df
to
1a7c59b
Compare
eshanholtz
approved these changes
Oct 23, 2020
idelgado
suggested changes
Oct 26, 2020
idelgado
approved these changes
Oct 26, 2020
eshanholtz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR adds
AccessTokenOptions.regionparameter to support regional authentication. This value will be encoded in thetwrheader of the JWT. If the parameter is not specified or invalid, notwrvalue is added. See this document for more details.JIRA: https://issues.corp.twilio.com/browse/CLIENT-8142
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.