Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose internal RequestClient to users at top level #668

Merged
merged 1 commit into from
Mar 31, 2021
Merged

chore: expose internal RequestClient to users at top level #668

merged 1 commit into from
Mar 31, 2021

Conversation

stern-shawn
Copy link
Contributor

@stern-shawn stern-shawn commented Mar 30, 2021

Fixes

Exposes the internal RequestClient so users don't need to import relying on twilio-node's file structure, ex: const RequestClient = require('twilio/lib/base/RequestClient'); and can instead import via:

const twilio = require('twilio');

const { RequestClient } = twilio;

The use case is when users are writing some type of custom client but they don't want to directly access axios, etc and instead want to lean on Twilio's existing client, for example:

const twilioClient = twilio(accountSid, authToken, {
  httpClient: new CustomRedirectClient('http://localhost:8080/mock-server', new RequestClient()),
});

Adds RequestClient to typedefs.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added the necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@childish-sambino childish-sambino merged commit 04f9e91 into twilio:main Mar 31, 2021
@stern-shawn stern-shawn deleted the feat/expose-request-client branch March 31, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants