Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updated url-parse dependency to address security issue #686

Merged
merged 1 commit into from
Aug 13, 2021
Merged

chore: Updated url-parse dependency to address security issue #686

merged 1 commit into from
Aug 13, 2021

Conversation

dmurawsky
Copy link
Contributor

Fixes #685

Upgrading url-parse dependency to handle security issue: GHSA-hh27-ffr2-f2jc

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@dmurawsky dmurawsky changed the title update url-parse Updated url-parse dependency to address security issue Aug 12, 2021
@shwetha-manvinkurke shwetha-manvinkurke changed the title Updated url-parse dependency to address security issue chore: Updated url-parse dependency to address security issue Aug 12, 2021
shwetha-manvinkurke
shwetha-manvinkurke approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dmurawsky dmurawsky mentioned this pull request Aug 13, 2021
Closed
@shwetha-manvinkurke shwetha-manvinkurke merged commit 34296a3 into twilio:main Aug 13, 2021
@shwetha-manvinkurke shwetha-manvinkurke added the type: security known security issue label Aug 13, 2021
@JenniferMah JenniferMah mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke approved these changes

Assignees
No one assigned
Labels
type: security known security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update url-parse dependency
2 participants
@dmurawsky @shwetha-manvinkurke