fix: done callback execution when each method limit reached #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
For resources that contain an
each
method to stream records from the API until a limit is reached, itsopts.done
callback fails to execute when the user defines a limit in theopts
object and it is reached.Changes include new tests for testing that:
opts.done
callback is executed when incomingPhoneNumber records processedopts.done
callback is executed when a user defined limit is reached for incomingPhoneNumber recordsChecklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.