Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub release step during deploy #720

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

childish-sambino
Copy link
Contributor

No description provided.

@@ -52,15 +59,14 @@ jobs:
- name: Get tagged version
run: echo "GITHUB_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

- name: Create GitHub Release
uses: sendgrid/dx-automator/actions/release@main
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a footer here as well with the npm package link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it's not something we currently do so just trying to match the existing implementation before enhancing.

@childish-sambino childish-sambino merged commit 7e2c296 into main Jan 7, 2022
@childish-sambino childish-sambino deleted the release-action branch January 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants