Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a timeout options to RequestClient that creates a custom https agent #775

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

benweissmann
Copy link
Contributor

Fixes

This PR improves handling of timeouts and axios options in RequestClient. It:

  • Accepts a new timeout option to the RequestClient constructor
  • Constructs a custom https Agent with the timeout applied. This ensures that timeouts are applied both at the socket level, and at the request/response level. See: Allow a connect timeout to be specified axios/axios#1739
  • Moves construction of the HttpsProxyAgent to the constructor to avoid creating a new agent for each request
  • Creates an axios instance rather than mutating axios defaults

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@rakatyal
Copy link
Contributor

Thanks for the contribution, changes look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants