Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing header parameter issues in twilio-python #625

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

AsabuHere
Copy link
Contributor

Fixes

A short description of what this PR does.
Fixing header parameter issues in twilio-python

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@AsabuHere AsabuHere changed the base branch from main to fix_orgs_api December 3, 2024 10:51
@AsabuHere AsabuHere changed the base branch from fix_orgs_api to main December 3, 2024 10:52
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed for 'twilio-oai-generator-python'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
18.8% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@AsabuHere AsabuHere changed the base branch from main to fix_orgs_api December 3, 2024 11:15
@AsabuHere AsabuHere merged commit 317a577 into fix_orgs_api Dec 3, 2024
14 of 19 checks passed
@AsabuHere AsabuHere deleted the python_fix_headers branch December 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant