feat: Organizations Api uptake for twilio-python #815
Conversation
* chore: oauth sdk implementation
|
|
||
| if not self.username or not self.password: | ||
| raise TwilioException("Credentials are required to create a TwilioClient") | ||
| self.credential_provider = credential_provider or None |
There was a problem hiding this comment.
Check this with Kridai, if existing customers use TwilioException - this is a breaking change
There was a problem hiding this comment.
Check if the exception being thrown as 401 is getting wrapped in TwilioException and being sent to customer
There was a problem hiding this comment.
For the below cases
- No username password provided
- Wrong username password provided
TwilioRestException is thrown now
Is this a breaking change?
| from twilio.base.domain import Domain | ||
| from typing import Optional | ||
| from twilio.rest import Client | ||
|
|
There was a problem hiding this comment.
generate from librarian and add it and commit it
There was a problem hiding this comment.
librarian generation has issues currently. This needs to be fixed before generating and adding these files
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
| exp = decoded.get("exp") | ||
|
|
||
| if exp is None: | ||
| return True # No expiration time present, consider it expired |
Check failure
Code scanning / SonarCloud
JWT should be signed and verified
| exp = decoded.get("exp") | ||
|
|
||
| if exp is None: | ||
| return True # No expiration time present, consider it expired |
Check failure
Code scanning / SonarCloud
JWT should be signed and verified High
|
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.