Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed query param not going for delete #693

Merged
merged 5 commits into from
Jan 2, 2024
Merged

fix: fixed query param not going for delete #693

merged 5 commits into from
Jan 2, 2024

Conversation

manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Dec 14, 2023 •
edited
Loading

Fixes

Fix done: HTTP client will now send params and data both

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 changed the title bug: fixed query param not going for delete fix: fixed query param not going for delete Dec 14, 2023
@manisha1997 manisha1997 changed the title fix: fixed query param not going for delete bug: fixed query param not going for delete Dec 14, 2023
@manisha1997 manisha1997 changed the title bug: fixed query param not going for delete fix: fixed query param not going for delete Dec 14, 2023
@manisha1997 manisha1997 marked this pull request as draft December 14, 2023 14:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manisha1997 manisha1997 marked this pull request as ready for review December 15, 2023 06:45
tiwarishubham635
tiwarishubham635 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrutiburman shrutiburman merged commit cec034b into main Jan 2, 2024
28 checks passed
@shrutiburman shrutiburman deleted the query-param-delete branch January 2, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman left review comments

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

@AsabuHere AsabuHere Awaiting requested review from AsabuHere

@sbansla sbansla Awaiting requested review from sbansla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manisha1997 @tiwarishubham635 @shrutiburman