Release 4.5.0, merge feature/media-optimizations #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Client track switch off is enabled by default * The app does not implement any specific manual controls, this is effectively the legacy behavior without maxTracks * Remove renderer when cell is not visible * Remove maxTracks from the app. * Use 4.5.0-rc1. * Update pods * Remove renderer when video track changes * Fix podfile Co-authored-by: Tim Rozum <trozum@twilio.com>
* Use 4.5.0-rc4. [skip ci] * Add support for video content preferences. * Ability to select VCP in settings * ConnectOptionsFactory applies the settings * SettingsStore provides storage / default value * Remove unused VideoDimensionsName class. * Commit missing factory. * Use mock generator to fix mock * Fix pods Co-authored-by: Tim Rozum <trozum@twilio.com>
Merge master into feature/media-optimization
ceaglest
commented
Aug 27, 2021
| @@ -1,3 +1,5 @@ | |||
| source 'https://cdn.cocoapods.org/' | |||
There was a problem hiding this comment.
Not required but nice to be explicit, IMHO.
There was a problem hiding this comment.
Yeah this way we don't have to change this when switching between public and private pod. I thoughts that how it was but it must have gotten removed somehow.
ceaglest
commented
Aug 27, 2021
timrozum
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update video-app-ios to take advantage of new APIs in 4.5.0
clientTrackSwitchOffModeandcontentPreferencesModeand migrate off the deprecated APIsmaxTracksandrenderDimensions.Testing
Contributing to Twilio