Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where getAudioAndVideoTracks was repeatedly called #363

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Nov 12, 2020

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This fixes a bug where getAudioAndVideoTracks is called repeatedly when there is a getUserMedia error. The repeated calls to getAudioAndVideoTracks result in the error message never being displayed to the user.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza merged commit 38be43a into master Nov 12, 2020
@timmydoza timmydoza deleted the fix-device-error branch November 12, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants