Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update with audio settings guidance #260

Merged

Conversation

kbagchiGWC
Copy link
Contributor

  • Updated README with Troubleshooting Audio section.
  • Updated code to pass non null OnAudioFocusChangeListener to requestAudioFocus.

…ity - requestAudioFocus now takes AudioManager.OnAudioFocusChangeListener instead of null listener.
@kbagchiGWC kbagchiGWC requested a review from aaalaniz April 8, 2019 18:48
@kbagchiGWC kbagchiGWC requested review from aymenn and idelgado April 11, 2019 17:00
@kbagchiGWC kbagchiGWC merged commit 829359b into twilio:3.x Apr 11, 2019
@kbagchiGWC kbagchiGWC deleted the readme_update_with_audio_settings_guidance branch April 11, 2019 20:14
aaalaniz pushed a commit that referenced this pull request Apr 26, 2019
* Use 3.0.0-preview1 (#192)

* Use 3.0.0-preview2 (#193)

* Use preview3. (#196)

* Migration guide (#197)

* Using 3.0.0-preview4. (#205)

Use preview4

* Use preview5. (#206)

* Updated README migration section with custom parameters support entries. (#207)

* New Features section (#212)

* Describe handleMessage callback behavior differences between 2.X and 3.X (#216)

* Use preview6. (#218)

* Implement hold functionality (#220)

* Use 3.0.0-beta1 (#223)

* Use Voice SDK 3.0.0-beta2 (#228)

* Task/update proguard rules (#229)

* Add push credential docs (#232)

* Use absolute URL so the Getting Started page resolves images (#236)

* Removed extra space (#238)

* Use Voice SDK 3.0.0-beta3 (#240)

* Use beta4 (#243)

* Update to 3.0.0-beta5 (#245)

* Consume Android Voice SDK 3.0.0-beta6 (#250)

Consume Android Voice SDK 3.0.0-beta6

* Use Voice Android SDK 3.0.0-beta7 (#252)

* Use Voice Android SDK 3.0.0-beta8 (#255)

* Moved out Migration guide and new feature sections  (#257)

* Moved out new features and migration guide sections and created new Docs files

Small updates to titles and renamed 3.x to 3.0 in some cases

* Made the "x" in "2.x" and "3.x" lower case

The "x" in "2.x" and "3.x" was inconsistent - in some cases lower case and in others upper case. This commit changes the "X" to lower case

* Use Voice Android SDK 3.0.0-beta9 (#258)

* Use Voice Android SDK 3.0.0-beta10 (#259)

* Improve param docs (#261)

* Readme update with audio settings guidance (#260)

* Use Voice Android SDK 3.0.0-beta10

* Updated README with troubleshooting audio section. Upadted VoiceActivity - requestAudioFocus now takes AudioManager.OnAudioFocusChangeListener instead of null listener.

* Use Voice Android SDK 3.0.0-beta11 (#262)

* Use Voice SDK 3.0.0_beta12 (#264)

* Use Voice SDK 3.0.0_beta13 (#265)

* Use Voice Android SDK 3.0.0 GA version (#266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants