This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Add New Features section in README #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bobiechen-twilio
commented
Nov 6, 2018
bobiechen-twilio
commented
- Add a new section for new features
- Update links
piyushtank
suggested changes
Nov 6, 2018
README.md
Outdated
|
|
||
| 1. [WebRTC](#webrtc) | ||
| 2. [Custom Parameters](#custom-parameters) | ||
| 3. [Ringing](#ringing) |
There was a problem hiding this comment.
Followed Android PR: twilio/voice-quickstart-android#212
README.md
Outdated
| 1. [WebRTC](#webrtc) | ||
| 2. [Custom Parameters](#custom-parameters) | ||
| 3. [Ringing](#ringing) | ||
| 4. [Stats](#media-stats) |
There was a problem hiding this comment.
Followed Android PR: twilio/voice-quickstart-android#212
README.md
Outdated
| 3. [Ringing](#ringing) | ||
| 4. [Stats](#media-stats) | ||
| 5. [TVODefaultAudioDevice](#tvodefaultaudiodevice) | ||
| 6. [TVOAudioDevice Protocol](#tvoaudiodevice-protocol) |
There was a problem hiding this comment.
How about -
5. Audio device APIs
a. Default audio device
b. Custom audio device
README.md
Outdated
| audioDevice.block(); | ||
| ``` | ||
|
|
||
| #### <a name="tvoaudiodevice-protocol"></a>TVOAudioDevice Protocol |
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### <a name="tvodefaultaudiodevice"></a>TVODefaultAudioDevide |
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### <a name="ringing"></a>Ringing |
There was a problem hiding this comment.
Followed Android PR: twilio/voice-quickstart-android#212
There was a problem hiding this comment.
Happy to make these changes on the Android side. They are less terse headings.
idelgado
approved these changes
Nov 7, 2018
piyushtank
approved these changes
Nov 8, 2018
README.md
Outdated
| 4. [Media Stats](#media-stats) | ||
| 5. [Audio Device APIs](#audio-device-apis) | ||
| * [Default Audio Device](#default-audio-device) | ||
| * [Custom Audio Device](#custom-audio-device) |
piyushtank
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.