Remove mock from setup.py installation requires #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ python: | |||
|
|
|||
| install: | |||
| - pip install -q $TWISTED | |||
| - pip install -q mock | |||
There was a problem hiding this comment.
Is it necessary to put it into a new line?
There was a problem hiding this comment.
Not at all! Would it be better all on a single line? :)
There was a problem hiding this comment.
Since both are test dependencies, I would prefer that I guess but it’s not my project. :)
|
Now with 100% less new lines ;) (cc: @hynek ) |
|
Such compression much effectivity so merge. Wow. |
| @@ -12,7 +12,7 @@ python: | |||
| - pypy | |||
|
|
|||
| install: | |||
| - pip install -q $TWISTED | |||
| - pip install -q $TWISTED mock | |||
There was a problem hiding this comment.
FWIW, travis comes with mock installed: http://about.travis-ci.org/docs/user/languages/python/#Pre-installed-packages
There was a problem hiding this comment.
Oh, brilliant. I'll fix this then...
dreid
added a commit
that referenced
this pull request
Jan 2, 2014
Remove mock from setup.py installation requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves it to travis' config too, so it can use it for tests
for #32, cc @hynek