Use Tox for testing #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! This now works - has it for Twisted 12.1-13.2, + trunk, + 'current' (so that if Twisted updates, we're still targeting the most recent without a Klein change). I manually put them in, so that you can run all of these tests locally, without having to use Travis to do it and without having to mess around with anything else. I also added a pyflakes tox entry. This errors because this branch doesn't have the changes fixing the pyflakes errors. Otherwise, everything is green! |
|
I looked at it and the respective Travis outputs and it LGTM. This will make local development much better. \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about using tox for testing.
It's not done yet, just wanting to see how Travis handles it.