Support using Klein instances as class variables to decorate methods. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self._instance is None: | ||
| self._instance = instance | ||
|
|
||
| return self |
There was a problem hiding this comment.
This whole method isn't reentrant. I was going to suggest checking self._instance to make sure it wasn't bound to anything, but that breaks if you ever have two instances of the class this Klein is attached to.
| @@ -45,9 +45,12 @@ class Klein(object): | |||
| @ivar _endpoints: A C{dict} mapping endpoint names to handler functions. | |||
| """ | |||
|
|
|||
| _bound_klein_instances = {} | |||
There was a problem hiding this comment.
This should probably be a weakref.WeakValueDictionary so it doesn't prevent garbage collection of instances using bound Kleins.
dreid
added a commit
that referenced
this pull request
Feb 27, 2013
Support using Klein instances as class variables to decorate methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.