Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use incremental to canonicalize versions for release #329

Merged
merged 3 commits into from
Mar 20, 2021

Conversation

altendky
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #329 (fad21ca) into master (dfaa241) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          20       20           
  Lines        1183     1183           
  Branches      106      106           
=======================================
  Hits         1145     1145           
  Misses         20       20           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaa241...fad21ca. Read the comment docs.

@altendky altendky marked this pull request as ready for review March 19, 2021 15:01
@altendky altendky requested a review from a team March 19, 2021 15:01
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preferred to use some pip / stdlib / package version so that we don't have yet another version standard.

But as you are the maintainer of this library, I don't see any critical issue with this change.

I don't think that it's worth spending more time arguing about which version scheme is better.
We only have one life :)

Thanks!

@altendky
Copy link
Member Author

I mentioned to @adiroiban that I am not particular attached to incremental. I just figured the branch etc names ought to match what will show up on PyPI and pip list etc. If we change that then yeah, I might tend back towards PEP440 normalization everywhere.

@altendky altendky merged commit 499c8f7 into twisted:master Mar 20, 2021
@altendky altendky deleted the canonicalize_with_incremental branch March 20, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants