Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle empty issue names #656

Merged
merged 6 commits into from
Aug 6, 2024
Merged

handle empty issue names #656

merged 6 commits into from
Aug 6, 2024

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Aug 6, 2024 •
edited
Loading

Description

Fixes #655

allow non-issue fragments when using issue_pattern.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

@dorschw dorschw requested a review from a team as a code owner August 6, 2024 14:38
adiroiban
adiroiban approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

src/towncrier/newsfragments/655.bugfix.rst Outdated Show resolved Hide resolved
@adiroiban
Copy link
Member

Thanks for the update. Auto-merge was enabled.

auto-merge was automatically disabled August 6, 2024 14:48

Head branch was pushed to by a user without write access

@adiroiban adiroiban merged commit 4aa8174 into twisted:trunk Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no issue names are considered invalid when using issue_pattern
2 participants
@dorschw @adiroiban