Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably breaks with eager task factory #11

Open
twisteroidambassador opened this issue Nov 15, 2024 · 0 comments
Open

Probably breaks with eager task factory #11

twisteroidambassador opened this issue Nov 15, 2024 · 0 comments

Comments

@twisteroidambassador
Copy link
Owner

Haven't checked, but it looks like the current implementation will trip an AssertionError when used with eager_task_factory introduced in Python 3.12.

Will need to add test for it, and fix if fails.

Refer to cpython's fix for it:
https://github.com/python/cpython/blob/main/Lib/asyncio/staggered.py
python/cpython#124847

Also check out https://github.com/aio-libs/aiohappyeyeballs and see their solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twisteroidambassador