Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124309: fix staggered race on eager tasks #124847

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-124309: fix staggered race on eager tasks #124847

wants to merge 3 commits into from
+82 −3

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 1, 2024 •
edited by bedevere-app bot
Loading

graingert and others added 2 commits October 1, 2024 14:39
@graingert @ZeroIntensity
restore tests from reverted commits
c03e43f 
Co-Authored-By: Peter Bierma <zintensitydev@gmail.com>
@graingert
in asyncio.staggered wait for the current task to resume before start…
c936c0f 
…ing work on child tasks
@graingert graingert changed the title restore tests from reverted commits gh-124309: fix staggered race on eager tasks Oct 1, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 1, 2024
Open
@ZeroIntensity ZeroIntensity mentioned this pull request Oct 1, 2024
Open
1 task
@graingert graingert marked this pull request as ready for review October 1, 2024 15:36
@ZeroIntensity
Copy link
Member

I'm marking this as DO-NOT-MERGE for the time being. aiohttp is planning on trying this sometime this week.

@gvanrossum
Copy link
Member

aiohttp is planning on trying this sometime this week

Hopefully you will test with a range of aiohttp versions -- the previous version of this PR seemed to work on some but not on others.

@ZeroIntensity
Copy link
Member

Yeah, that's the idea. We might not even need this PR if their new implementation turns out to work perfectly.

@gvanrossum
Copy link
Member

Don't we still need to do something to make eager tasks work? Or does that problem only occur in combination with aiohttp? Presumably there's at least one previous aiohttp version where the current main (or 3.12) branch doesn't work with aiohttp (or I don't understand the issue).

@ZeroIntensity
Copy link
Member

Our implementation (on main and 3.12) doesn't work with eager task factories, and most aiohttp versions (apart from the latest, IIUC, because they made their own) rely on our implementation.

@gvanrossum
Copy link
Member

Our implementation (on main and 3.12) doesn't work with eager task factories, and most aiohttp versions (apart from the latest, IIUC, because they made their own) rely on our implementation.

So we definitely have to change something right?

@ZeroIntensity
Copy link
Member

Yup, I'm just cautious because I don't want to break prior aiohttp versions on accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
awaiting review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @ZeroIntensity @gvanrossum