Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just some leftovers from #8, I apologize :) #12

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Just some leftovers from #8, I apologize :) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/note.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ impl Add<Interval> for Note {
// Basically, if we were already "on" the weird one (this is a perfect unision, or perfect octave, etc.), then we don't
// do anything special. Otherwise, if we landed on on of these edge cases, then we need to adjust the octave.
let mut special_octave = 0;

if self.named_pitch != new_pitch {
if new_pitch == NamedPitch::CFlat
|| new_pitch == NamedPitch::CDoubleFlat
Expand Down Expand Up @@ -459,7 +459,7 @@ impl Sub<Interval> for Note {
// Basically, if we were already "on" the weird one (this is a perfect unision, or perfect octave, etc.), then we don't
// do anything special. Otherwise, if we landed on on of these edge cases, then we need to adjust the octave.
let mut special_octave = 0;

if self.named_pitch != new_pitch {
if new_pitch == NamedPitch::CFlat
|| new_pitch == NamedPitch::CDoubleFlat
Expand Down