Server JSON responses using EmitDefaults #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be overriden with a server option
This was referenced Sep 14, 2020
ccmtaylor
added a commit
to soundcloud/twinagle
that referenced
this pull request
Nov 3, 2020
Upstream Twirp recomends this behaviour to reduce confusion. This is fully backwards-compatible. See-Also: twitchtv/twirp#271
ccmtaylor
added a commit
to soundcloud/twinagle
that referenced
this pull request
Nov 3, 2020
Upstream Twirp recomends this behaviour to reduce confusion. This is fully backwards-compatible. See-Also: twitchtv/twirp#271
ccmtaylor
added a commit
to soundcloud/twinagle
that referenced
this pull request
Nov 11, 2020
Upstream Twirp recomends this behaviour to reduce confusion. This is fully backwards-compatible. See-Also: twitchtv/twirp#271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #103
Generated Twirp servers include default values on JSON responses by default. JSON Marshaller uses
EmitDefault: trueby default.This is configurable through the server option:
twirp.WithServerJSONSkipDefaults(true). If the option is set, JSON responses will not include empty values. This may be useful to save bandwidth, or to enable full backwards compatibility if the previous behavior was really to somebody.This solution is similar to the one proposed on #134, except for the following differences:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.