Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated file name error in some cases #351

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

albenik
Copy link
Contributor

@albenik albenik commented Feb 11, 2022

Closes #350

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mellis
Copy link
Contributor

mellis commented Mar 8, 2022

LGTM, thank you for the PR.

@mellis mellis merged commit 68a69dc into twitchtv:main Mar 8, 2022
@albenik albenik deleted the fix-protoc-gen-twirp branch March 8, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Wrong generated file name error with paths=imports option & module option without trailing slash
2 participants