This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced SenTest with XCTest.
I cleaned up the FRAMEWORK_SEARCH_PATHS to not to contain some junk, please reference https://github.com/seivan/CocoaSPDY/compare/twitter:develop...feature%2Fxctest?expand=1#diff-607867dba70c420bf87de2f213acf3afR761
I changed the deployment target to 7 for making sure the XCTest run.
However, I can't seem to get the actual tests to run. I just get an exit with 0, which means it does run the library but that's the end of it. It doesn't actually run the suite, care to throw some eyes on this?
https://travis-ci.org/twitter/CocoaSPDY/builds/15848795#L578
Now, I'd like to suggest getting rid of pre-built static frameworks for several reasons
Basically what I'm suggesting is doing local path (like bundler for ruby).
Let me know if you want a sample, I've done it for several libraries, and I could easily do a branch for demonstration here, but it also requires that we get rid of the static pre-built frameworks that honestly lacks any benefits compared to source code.