Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Feature/xctest #7

Closed
wants to merge 2 commits into from
Closed

Feature/xctest #7

wants to merge 2 commits into from

Conversation

seivan
Copy link
Contributor

@seivan seivan commented Dec 22, 2013

I replaced SenTest with XCTest.
I cleaned up the FRAMEWORK_SEARCH_PATHS to not to contain some junk, please reference https://github.com/seivan/CocoaSPDY/compare/twitter:develop...feature%2Fxctest?expand=1#diff-607867dba70c420bf87de2f213acf3afR761

I changed the deployment target to 7 for making sure the XCTest run.

However, I can't seem to get the actual tests to run. I just get an exit with 0, which means it does run the library but that's the end of it. It doesn't actually run the suite, care to throw some eyes on this?
https://travis-ci.org/twitter/CocoaSPDY/builds/15848795#L578

Now, I'd like to suggest getting rid of pre-built static frameworks for several reasons

  • You can still drag and drop a folder of source code as you could with pre-built static frameworks.
  • It allows for easier 'hotfixes' and promotes contributions
  • It allows for a better work flow for the maintainers, just set a local path for the pods/source and edit the sample/tests and it will reflect the changes directly.
  • You will work/test against the source/'pod' that the users of the library use.
  • You can run your test suites against forks of the pod for testing problems/bug reports easier.
  • It doesn't requiring pre-built frameworks
  • It doesn't requiring updating for new architectures
  • It allows for better debugging options

Basically what I'm suggesting is doing local path (like bundler for ruby).

Let me know if you want a sample, I've done it for several libraries, and I could easily do a branch for demonstration here, but it also requires that we get rid of the static pre-built frameworks that honestly lacks any benefits compared to source code.

Replace subclasses of SenTestCase with XCTestCase
Replace STAssertions to XTAssertions
Remove nil fail messages
Add string formatter to the fail messages.
Clean up FRAMEWORK_SEARCH_PATHS not to contain junk.
@goaway
Copy link
Collaborator

goaway commented Dec 30, 2013

Hey @seivan, no luck getting the tests to run here so far either. Need to find more time to investigate.

As for your suggested pod setup, I'm interested and would be happy to take a look at a branch if you don't mind setting one up. I'm not sure why it affects having a binary distribution available though.

@goaway
Copy link
Collaborator

goaway commented Mar 10, 2014

Closing this for now - while I'd like to move to XCTest, there hasn't been any progress on this pull request for a while.

@goaway goaway closed this Mar 10, 2014
@seivan
Copy link
Contributor Author

seivan commented Mar 10, 2014

@goaway I am sorry about that. Got caught in a crunch at work. I actually do have more time over. I will take a look at it over the weekend. Leaving it closed is a good idea for now :) Thanks for your patience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants