Introduce allowedNames config for ComposeNaming check
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't sure what to call the editorconfig property, let me know! Resolves twitter#104
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
|
|
Signed the CLA but looks like the CLA Assistant action fell over |
kenyee
reviewed
Oct 17, 2022
rules/common/src/main/kotlin/com/twitter/compose/rules/ComposeNaming.kt
Outdated
Show resolved
Hide resolved
We can override..it's been a bit finicky even for me... |
ZacSweers
commented
Oct 18, 2022
rules/common/src/main/kotlin/com/twitter/compose/rules/ComposeNaming.kt
Outdated
Show resolved
Hide resolved
mrmans0n
approved these changes
Oct 18, 2022
mrmans0n
reviewed
Oct 18, 2022
rules/ktlint/src/test/kotlin/com/twitter/compose/rules/ktlint/ComposeNamingCheckTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure what to call the editorconfig property, let me know!
Resolves #104