Reporter (see sbt/zinc#304) is the last blocker, afaict.

twitter · Jun 19, 2017 · 0e41a95 · 0e41a95
1 parent b84a989
commit 0e41a95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/scala/org/pantsbuild/zinc/InputUtils.scala b/src/scala/org/pantsbuild/zinc/InputUtils.scala
@@ -57,8 +57,9 @@ object InputUtils {
         false,
         settings.cacheFile,
         CompilerUtils.getGlobalsCache,
-        incOptions,
-        // TODO: No clear way to create a Reporter currently.
+        incOptions.options(log),
+        // TODO: No clear way to create a Reporter currently:
+        //   see https://github.com/sbt/zinc/pull/304
         ???,
         None.asJava,
         Array()

diff --git a/src/scala/org/pantsbuild/zinc/Settings.scala b/src/scala/org/pantsbuild/zinc/Settings.scala
@@ -176,6 +176,7 @@ case class IncOptions(
       useZincFileManager,
       recompileOnMacroDef.map(java.lang.Boolean.valueOf).asJava,
       true, // nameHashing
+      // TODO: what are the implications of disabling `storeApis`?
       false, // storeApis, apis is stored separately after 1.0.0
       false, // antStyle
       Map.empty.asJava, // extra