Add support for jsonp remote requests #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,6 +131,7 @@ The transport component is a singleton used by all typeaheads initialized with t | |||
|
|
|||
| * `maxConcurrentRequests` - The max number of AJAX requests typeahead.js can have pending. Defaults to `6`. | |||
|
|
|||
| * `dataType` - The jQuer ajax dataType option to use. Can be either `json` or `jsonp`. Defaults to `json`. | |||
|
Based on some of the feedback we've gotten so far, I think I may have to rewrite the transport component to make it a bit more flexible. I'll be sure to include this change in the rewrite. |
|
Sounds good, I look forward to seeing the update. |
Closed
|
How about using automatic detection to decide between json and jsonp _getDataType: function (url) {
//all of that because IE doesnt support location.origin
var origin = RegExp([ location.protocol, "//", location.host, location.port].join(""));
return origin.test(url) ? "json" : "jsonp";
},Or something along those lines. |
|
Closing in favor of #25. |
jlbooker
added a commit
to jlbooker/typeahead.js
that referenced
this pull request
Nov 10, 2016
Stop propagation when selecting an entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for setting the dataType for the transport.get request. Only supports json and jsonp. Defaults to json.