Patches #662
Merged
Patches #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See embedded comment. Not having this logic was making it look like issuing a request failed with something like NOT_LEADER_FOR_PARTITION (if there were enough retries) -- this is not a failed request, and _some_ of the response may be successful.
When I originally wrote this I was thinking I could use one struct for the request and response, but I changed that because I noticed the response names a field differently absolutely no reason. I forgot to remove Subject and Err in the SetCompatibility struct.
This takes all goroutines out of client initialization sub functions (ie not the explicit ones _in_ client initialization) and avoids starting a goroutine if we never even make it to the manage loop anyway (which only happens once we finally fetch metadata) Also skips autocommitting if there is nothing to commit. This is the same behavior as previously, but now we have a log that explicitly says the commit is being skipped.
…titions" This restriction existed originally before AddConsumeTopics came into being. Now that AddConsumeTopics exists, we can just preemptively seed the client with all topics we are setting the offsets of, and then set the offsets.
VersionStrings and FromString will make it easy to write tests that iterate over all known broker versions.
If a topic has a load error, findNewAssignments will return new assignments for topics that have no partitions. This emits extraneous log lines and looks like progress is being made when it isn't,
A consumer should be notified when it cannot make progress due to metadata load errors. We now * unconditionally inject a fake fetch if a load error is not retryable * inject a fake fetch if the user has configured KeepRetryableFetchErrors
Failing in CI without unlimited retries (i.e. slow cluster).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.