-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speech commands explanatory model #1869
Speech commands explanatory model #1869
Conversation
Most of the non-trivial changes here were needed because the code for the fairness metrics assumed that the explanatory model was a pytorch model, but the speech commands one is tensorflow. It also assumed image data, while speech commands is audio. This should work for eval6. It makes no pretense to general applicability, meaning It is possible that future model architectures might require additional changes; but that's hard to predict. |
@lcadalzo could you review when you get a chance |
@lcadalzo the latest commits should address your points, let me know if there's anything else |
I had to change On laptop, using
And on remote cluster using a GPU:
Have you been able to run this code successfully? Are you able to reproduce this? Note: to make this run much faster, I'm also commenting out the |
If you are running an audio config you may have to use
Not sure if that's the issue you are hitting; it's not a very descriptive error. |
Ok I was finally able to replicate your error by skipping training and not using fit_generator. If I train but don't use fit_generator I get OOM. |
@lcadalzo In case I wasn't clear, I don't believe the error you hit is an issue because it can be avoided by using fit_generator. |
What's the rationale behind fit_generator being a configurable scenario kwarg? |
It runs more slowly but uses less memory. Some users may not find it necessary. See the discussion at 1761 and the info David added to the poisoning doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds explanatory model for poisoning fairness metrics.
Also corrects for an ART bug where triggered audio samples go out of range.